Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Links Job Gets Rate Limited #7877

Closed
czarcas7ic opened this issue Mar 27, 2024 · 3 comments · Fixed by #8272
Closed

Broken Links Job Gets Rate Limited #7877

czarcas7ic opened this issue Mar 27, 2024 · 3 comments · Fixed by #8272

Comments

@czarcas7ic
Copy link
Member

Background

See #7752

Every error is from the job getting rate limited

Suggested Design

Change the job to only query x per second so it no longer gets rate limited

Acceptance Criteria

Broken link detector job detects broken links instead of getting rate limited

@deividaspetraitis
Copy link
Contributor

deividaspetraitis commented May 9, 2024

It seems there is no available option to specify request limiting per interval i. One of possible solutions may be running checks more frequently ( let's say every few hours ) and let failed requests to be retried on the next run while succesfull ones can be cached, let's say for 24h. Feature to cache only successfully checked links was already proposed in lycheeverse/lychee#1400 including a pull request implementing proposed functionality. I was wondering, would that work for our case?

@czarcas7ic
Copy link
Member Author

Surely there is an option to make the action run longer, but reduce the rate of requests right?

@czarcas7ic
Copy link
Member Author

Tbh this doesn't need to run often, just need a general idea of we have broken links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants