-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SQS): custom quote query #7001
Conversation
// Skip routes that do not match the pool length. | ||
if len(routePools) != len(poolIDs) { | ||
continue | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider in the future adding length to GetRoutesFromCandidates to prevent having to iterate over them again here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm note sure what recommendation is exactly. We would have to iterate anyways since we want to make sure each pool's ID matches the id of the given list of pool IDs in the same order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will not be blocking on this, please lmk if any follow-ups are needed
* feat(SQS): custom quote query * lint * add test for ParseNumbers (cherry picked from commit 8214a60)
* feat(SQS): custom quote query * lint * add test for ParseNumbers (cherry picked from commit 8214a60)
Closes: #XXX
What is the purpose of the change
There are cases where it might be desired to specify a specific query path for quoting. This is especially useful for debugging.
As a result, such query is exposed.
It takes a list of pool IDs. If there is a route that mathes these pool IDs, such route is quotes. Otherwise, an error is returned.
Example:
Testing and Verifying
Go test added with uion/uosmo
Documentation and Release Note
Unreleased
section ofCHANGELOG.md
?Where is the change documented?
x/{module}/README.md
)