Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Polar to GitHub grammars list #1541

Closed
micalevisk opened this issue Mar 16, 2022 · 6 comments
Closed

Add Polar to GitHub grammars list #1541

micalevisk opened this issue Mar 16, 2022 · 6 comments

Comments

@micalevisk
Copy link

Can you guys make a request (or even implement 😄) on https://github.com/github/linguist to support Polar as a new language so we can get syntax highlighting from .polar files?

image

@patrickod
Copy link
Contributor

patrickod commented Mar 16, 2022

hey @micalevisk thanks for writing in 👋🏻

this is something we have definitely considered in the past. The Github linguist repository imposes some usage/popularity thresholds which languages must past before they quality for inclusion. specifically they require that the extension be used in 200+ unique repositories, which we unfortunately do not meet at this moment.

we have been keeping eye on the usage stats over time and hope to submit as soon as we qualify - we agree it would be a much better experience to have the full syntax highlighting functionality when browsing policies on Github!

@ngouy
Copy link

ngouy commented Sep 8, 2022

the criteria may be about to change:
github-linguist/linguist#5756
And you are probably close to meeting the 200+ repos
Also it's a weird requirement as the search cannot index private repo, which may be a good part of your users...

@gneray
Copy link
Contributor

gneray commented Sep 12, 2022

Looking at this again

@samscott89
Copy link
Member

@gj gj reopened this Oct 13, 2022
@samscott89
Copy link
Member

Done! It's now live!

@ngouy
Copy link

ngouy commented Nov 15, 2022

let's go

Thanks a lot!! You guys are awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants