Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies for ros1-bridge demos #341

Merged
merged 2 commits into from
Dec 2, 2019
Merged

Conversation

mikaelarguedas
Copy link
Contributor

This is a follow up of ros2/ros1_bridge#228

The bride images should provide the packages providing talker and listener in their ROS 1 and 2 form for basic testing / tutorial to be possible out of the box

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@ruffsl
Copy link
Member

ruffsl commented Dec 2, 2019

I like the idea. How much does this increase the size of the bridge image?
I'm guessing the demo's rope in a lot of extra packages though.

@mikaelarguedas
Copy link
Contributor Author

Apparently 12MB of extra disk space:

The following additional packages will be installed:
  ros-eloquent-example-interfaces
The following NEW packages will be installed:
  ros-eloquent-demo-nodes-cpp ros-eloquent-demo-nodes-py
  ros-eloquent-example-interfaces
0 upgraded, 3 newly installed, 0 to remove and 16 not upgraded.
Need to get 1008 kB of archives.
After this operation, 12.2 MB of additional disk space will be used.

The ros1-bridge deb already pulls in the ros1 tutorial packages (ros2/ros1_bridge#228)

@mikaelarguedas
Copy link
Contributor Author

Given the very limited footprint of this and the benefit for tutorials and consistency I'm going to go ahead and integrate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants