Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use semantic versioning #1848

Closed
vincentbernat opened this issue Oct 22, 2018 · 2 comments
Closed

Use semantic versioning #1848

vincentbernat opened this issue Oct 22, 2018 · 2 comments

Comments

@vincentbernat
Copy link
Contributor

Hey!

When embedding GoBGP into another project, Go 1.11 doesn't recognize the version number as it doesn't follow semantic versioning. For next version, could you use 1.34.0 instead of 1.34? To test:

$ GO111MODULE=on go get github.com/osrg/gobgp@v1.33
go: finding github.com/osrg/gobgp v1.33.0
go: github.com/osrg/gobgp@v1.33.0: unknown revision v1.33.0
go: error loading module requirements
@fujita
Copy link
Member

fujita commented Oct 24, 2018

Surely, I will do with the next release.

@fujita
Copy link
Member

fujita commented Dec 30, 2018

Done. Will switch from dep to mod soon too.

@fujita fujita closed this as completed Dec 30, 2018
This was referenced Jan 6, 2021
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vincentbernat @fujita