Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcp-mss is defined but doesn't seem to be effect #2666

Closed
jtollet opened this issue Jun 9, 2023 · 2 comments
Closed

tcp-mss is defined but doesn't seem to be effect #2666

jtollet opened this issue Jun 9, 2023 · 2 comments

Comments

@jtollet
Copy link

jtollet commented Jun 9, 2023

Hello,
in file https://github.com/osrg/gobgp/blob/master/internal/pkg/config/bgp_configs.go I can see a mention of TCP MSS setting:
// original -> bgp:tcp-mss
// Sets the max segment size for BGP TCP sessions.
TcpMss uint16 mapstructure:"tcp-mss" json:"tcp-mss,omitempty"

However, looking at the code, it seems it doesn't have an impact. Are you planning to support this parameter ?

@fujita
Copy link
Member

fujita commented Jun 9, 2023

Please send a pull request for it.

@fujita
Copy link
Member

fujita commented Jul 25, 2023

thanks!

@fujita fujita closed this as completed Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants