Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebApp HTML Report should show number of open security vulnerabilities vs. all #5335

Open
hanna-modica opened this issue May 9, 2022 · 8 comments
Assignees
Labels
enhancement Issues that are considered to be enhancements reporter About the reporter tool

Comments

@hanna-modica
Copy link
Contributor

It would be nice, if the resolved security vulnerabilities could be shown in the summary of the tab (similar to the rule violations) in the form (x/y).
In the attached screenshot 4 vulnerabilities are found, all of which were accepted locally - thus it would be nice if they could be shown as (0/4) in the summary.

grafik

@sschuberth sschuberth added enhancement Issues that are considered to be enhancements reporter About the reporter tool labels May 9, 2022
@tsteenbe
Copy link
Member

@sschuberth Looks like we have to have another discussion about this, if I remember it correctly the last time we decided that resolved vulnerabilities would be a rule violations topic so therefore you did not want to introduce a open_vulnerabilities in statistics.

@sschuberth
Copy link
Member

We probably indeed need a follow-up discussion. What I remember / understood back then is that for vulnerabilities that you have to address (e.g. because of their severity) rules should be created. However, as you can resolve vulnerabilities in ORT independently of rule violations, it also makes sense to display how many vulnerabilities are unresolved.

@hanna-modica
Copy link
Contributor Author

Hi everyone, I am also on @sschuberth's side and think, since those vulnerabilities are independent of the policies. Can you start the discussion?

@hanna-modica
Copy link
Contributor Author

Hi everyone,
did you make a decision yet? I agree with @sschuberth, that since you can resolve vulnerabilites even if they do not trigger a violation, if would be nice to have this information in the report.

@sschuberth
Copy link
Member

@hanna-modica please ask someone from your team to add this to the agenda of an upcoming community meeting to start the discussion.

@sschuberth
Copy link
Member

I agree with @sschuberth, that since you can resolve vulnerabilites even if they do not trigger a violation, if would be nice to have this information in the report.

We brought this up in the community meeting and @tsteenbe promised to implement this some time in December.

@hanna-modica
Copy link
Contributor Author

Hi @sschuberth and @tsteenbe, since December has passed, can you give a new estimation, when this will probably be implemented?

@sschuberth
Copy link
Member

I'm out of the loop here, relying on @tsteenbe to answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues that are considered to be enhancements reporter About the reporter tool
Projects
None yet
Development

No branches or pull requests

3 participants