Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extending URL prefix replacements for Git #8500

Closed
oheger-bosch opened this issue Apr 9, 2024 · 3 comments
Closed

Allow extending URL prefix replacements for Git #8500

oheger-bosch opened this issue Apr 9, 2024 · 3 comments
Labels
duplicate An issue that duplicates another issue

Comments

@oheger-bosch
Copy link
Member

The Git class currently has a hard-coded configuration for replacing URL prefixes, which is limited to replacing the prefix git:// by https://.

In our environment, there was the need to replace a URL like "git@github.com:" (used as a submodule reference and interpreted as SSH) by the URL "https://github.com/". I assume that such replacements cannot be done by ORT in a generic way, since the prefix to be replaced contains a domain; from my research, I found that Git currently does not support wildcards in its prefix mappings. So, it would be nice if there was a straight-forward way to modify the replacement configuration used by Git.

Since version control systems are implemented as plugins, would it make sense to support a similar configuration mechanism as for other types of plugins? Via this mechanism, other hard-coded settings (for instance the history depth) could be made configurable as well.

@sschuberth
Copy link
Member

@oheger-bosch, would you agree that this request can be considered as a duplicate of #6698?

@oheger-bosch
Copy link
Member Author

@sschuberth, thank you for pointing this out. Yes, there is at least a very strong relation between these issues, the same use cases are addressed. Not sure whether the aspect of making the VCS provider itself configurable is new though; the referenced issue seems to focus more on other strategies.

@sschuberth sschuberth added the duplicate An issue that duplicates another issue label Apr 9, 2024
@sschuberth
Copy link
Member

Let's then track these requests together in #6698 as discuss there.

@sschuberth sschuberth closed this as not planned Won't fix, can't repro, duplicate, stale Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate An issue that duplicates another issue
Projects
None yet
Development

No branches or pull requests

2 participants