Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduce a closing tag missing event or any HTML code with errors to see how core reacts #233

Open
FanJups opened this issue Apr 24, 2023 · 0 comments
Labels
information good to know jsgenerator-core core module question Further information is requested to verify check to see if something is wrong

Comments

@FanJups
Copy link
Member

FanJups commented Apr 24, 2023

It's a bad practice to not add required closing tag, the browser does its best to handle but it is not safe. In that kind of situation, how should we react ? Inform the user ? I think before translating, we should inform the user to make sure the html code is correct because the app will do the best it can to provide a Js code matching HTML input. If possible, we should inform the user if something is wrong. As an illustration, Google translate tries to understand your input and makes proposal "Did you mean: ...." if something is going wrong.

We could have something like this:

Please, before processing with the conversion, follow these links to verify if your HTML code is correct :

https://www.aliciaramirez.com/closing-tags-checker/
https://validator.w3.org/#validate_by_input

We started talking about it here : #157

@FanJups FanJups added jsgenerator-core core module todo Ticket that has to be done information good to know question Further information is requested to verify check to see if something is wrong and removed todo Ticket that has to be done labels Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
information good to know jsgenerator-core core module question Further information is requested to verify check to see if something is wrong
Projects
None yet
Development

No branches or pull requests

1 participant