Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End-to-end tests for workflow_dispatch #179

Closed
laurentsimon opened this issue Apr 15, 2022 · 5 comments
Closed

End-to-end tests for workflow_dispatch #179

laurentsimon opened this issue Apr 15, 2022 · 5 comments
Assignees

Comments

@laurentsimon
Copy link
Contributor

We need to trigger a "manual" workflow_dispatch event using this API https://docs.github.com/en/rest/reference/actions#create-a-workflow-dispatch-event

/cc @naveensrinivasan

@laurentsimon laurentsimon changed the title Unit tests for workflow_dispatch End-to-end tests for workflow_dispatch Apr 15, 2022
@naveensrinivasan naveensrinivasan self-assigned this Apr 15, 2022
@laurentsimon
Copy link
Contributor Author

laurentsimon commented Apr 18, 2022

  1. Workflow dispatch for golang branch https://github.com/ossf-tests/scorecard-action/blob/90f8df25accc87559287ef3d4ad8e6f151c9f1df/.github/workflows/workflowdispatch-golang.yml#L1

Questions:

  1. Should https://github.com/ossf-tests/scorecard-action/blob/main/.github/workflows/scorecards-golang.yml have the workflow_dispatch?
  2. Should https://github.com/ossf-tests/scorecard-action/blob/90f8df25accc87559287ef3d4ad8e6f151c9f1df/.github/workflows/workflowdispatch-golang.yml#L1 be changed to a different branch? We want to test that the brain scorecard runs on is not the default one, right? Actually, I think we need 1) the workflow you have (workflow defined on different branch and using its own branch to run scorecard ), 2) a workflow defined in default branch running scorecard on non-main branch, 3) (maybe?) a workflow defined on non-main branch running scorecard at main branch
  3. https://github.com/ossf-tests/scorecard-action/blob/90f8df25accc87559287ef3d4ad8e6f151c9f1df/.github/workflows/workflowdispatch-golang.yml#L36 does not need to workflow_dispatch, I think. At a schedule or push event, we trigger a workflow_dispatch to start https://github.com/ossf-tests/scorecard-action/blob/main/.github/workflows/scorecards-golang.yml.
    Please let me know if I mis-understand something. As it's setup, I'm under the impression the workflow_dispatch call will fail since the callee workflow does not have workflow_dispatch event defined.

@laurentsimon
Copy link
Contributor Author

@naveensrinivasan let me know if you have some update on this one. I've updated the doc in #203, saying that workflow_dispatch is experimental for now.

@naveensrinivasan
Copy link
Member

@naveensrinivasan let me know if you have some update on this one. I've updated the doc in #203, saying that workflow_dispatch is experimental for now.

Can we sync up to go over this?

@azeemshaikh38
Copy link
Contributor

workflow_dispatch e2e tests now setup and working. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants