-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goat counter issue on staging branch #75
Comments
Yeah I saw that. I am leaving in about 30 mins but I am going to look into this issue tomorrow |
Another question is - we are now making these changes (like disabling
Thanks! |
Yeah they will still work, and in that change which fixed the Goat counter issue, we actually enabled Ideally you need to move to Netlify sooner rather than later. It would be great if OSSF could get it setup now so we could easily port it over and make sure it is running on an optimal server for what you need. |
Hello all,
So after a bit of investigation it seems like Google App Engine has some issues with external scripts being loaded on static sites that are client-side only. I got to this conclusion by deploying exactly the same code to Netlify to see if I could replicate the issue there but it worked perfectly fine for me. The url is below:
https://staging-netlify-test--elastic-noether-393172.netlify.app/
I then changed the above env to use SSR(server side rendering) on the front-end so we aren't relying too much on the client-side and we get the added benefits of everything being loaded into the app state at once. This would then stop the issue of the external script being loaded before the client-side was ready breaking the site on refresh.
To further back up my thoughts, I have attached a screengrab of the associated env with the network tab open displaying the Goatcounter script publishing a count event.
I have now created a PR to go into the
main
branch for staging on Google App Engine with the same config settings as above. I will need this to be approved to merge into main then we can further test.#74
Thanks,
Mark
The text was updated successfully, but these errors were encountered: