From cc89464288983383aeda4051b56ec331c46f0aef Mon Sep 17 00:00:00 2001 From: Raghav Kaul Date: Fri, 21 Apr 2023 18:44:09 +0000 Subject: [PATCH] fix dangerous workflow test Signed-off-by: Raghav Kaul --- checks/evaluation/dangerous_workflow_test.go | 21 +++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/checks/evaluation/dangerous_workflow_test.go b/checks/evaluation/dangerous_workflow_test.go index 7726f33a64b..ae3eef25991 100644 --- a/checks/evaluation/dangerous_workflow_test.go +++ b/checks/evaluation/dangerous_workflow_test.go @@ -43,7 +43,23 @@ func TestDangerousWorkflow(t *testing.T) { r: &checker.DangerousWorkflowData{}, }, want: checker.CheckResult{ - Score: 10, + Score: checker.InconclusiveResultScore, + Reason: "no workflows found", + Version: 2, + Name: "DangerousWorkflow", + }, + }, + { + name: "DangerousWorkflow - found workflows, none dangerous", + args: args{ + name: "DangerousWorkflow", + dl: &scut.TestDetailLogger{}, + r: &checker.DangerousWorkflowData{ + NumWorkflows: 5, + }, + }, + want: checker.CheckResult{ + Score: checker.MaxResultScore, Reason: "no dangerous workflow patterns detected", Version: 2, Name: "DangerousWorkflow", @@ -55,6 +71,7 @@ func TestDangerousWorkflow(t *testing.T) { name: "DangerousWorkflow", dl: &scut.TestDetailLogger{}, r: &checker.DangerousWorkflowData{ + NumWorkflows: 1, Workflows: []checker.DangerousWorkflow{ { Type: checker.DangerousWorkflowUntrustedCheckout, @@ -82,6 +99,7 @@ func TestDangerousWorkflow(t *testing.T) { name: "DangerousWorkflow", dl: &scut.TestDetailLogger{}, r: &checker.DangerousWorkflowData{ + NumWorkflows: 1, Workflows: []checker.DangerousWorkflow{ { Type: checker.DangerousWorkflowScriptInjection, @@ -109,6 +127,7 @@ func TestDangerousWorkflow(t *testing.T) { name: "DangerousWorkflow", dl: &scut.TestDetailLogger{}, r: &checker.DangerousWorkflowData{ + NumWorkflows: 1, Workflows: []checker.DangerousWorkflow{ { Type: "foobar",