Checks within the SecurityPolicy checks makes it hard to test

[naveensrinivasan]

The security policy check instantiates repo client within the check which makes it hard to unit test

scorecard/checks/raw/security_policy.go

Lines 78 to 83 in fc87431

	dotGitHub := &checker.CheckRequest{
	Ctx: c.Ctx,
	Dlogger: c.Dlogger,
	RepoClient: githubrepo.CreateGithubRepoClient(c.Ctx, logger),
	Repo: c.Repo.Org(),
	}

[justaugustus]

@naveensrinivasan -- my team in Kubernetes Release Engineering maintains a GitHub package, which is pretty well-tested and would allow you to offload this.

Could you look around and see if some of this fits your needs?

https://github.com/kubernetes-sigs/release-sdk/blob/main/github/github.go

[naveensrinivasan]

@justaugustus We already have this capability within the scorecard. We use the GitHub library extensively. It so happens this code doesn't use the right method which makes it hard to write unit tests.

[justaugustus]

@naveensrinivasan — closing this as discussed in today's meeting that the code path has very likely changed since 2022. Feel free to reopen, if needed.