-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: docker-compose file with YAML directive breaking #2853
Comments
I'm guessing it's coming from here: scorecard/checks/raw/shell_download_validate.go Lines 957 to 962 in 1fb5960
Based on the comment, I'm guessing we aren't ignoring the error everywhere we call it. But I haven't tracked it down. |
So we used to catch it here: scorecard/checks/shell_download_validate.go Lines 810 to 822 in a004ffb
Until it was removed by this large PR #1932 @laurentsimon any idea if this was an intentional removal? |
Crashing the whole |
Describe the bug
A docker-compose file with YAML directive seems to break the Pinned-Dependencies check.
Reproduction steps
Steps to reproduce the behavior:
scorecard --repo=github.com/grpc/grpc
Expected behavior
I expected Scorecard to be able to parse docker-compose files with YAML directive.
Additional context
None.
The text was updated successfully, but these errors were encountered: