Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: scorecard to detect Binary Artifacts from local directory in command line (terminal) #3258

Closed
shilpaworld opened this issue Jul 10, 2023 · 1 comment · Fixed by #3415
Labels
check/Binary-Artifacts kind/bug Something isn't working

Comments

@shilpaworld
Copy link

shilpaworld commented Jul 10, 2023

Hi Team,

Note: Editing my originally raised issue:

We are trying to use scorecard for Binary Detection. Our aim is to detect binary in local folder. I was able to detect binaries in my personal github repo, however wasn't able to get results while executing on local folder using --local argument. I then built the code locally, added FileBased option in checks/binary_artifact.go init() and generated the build. The Binary Detection was successful. I was able to generate json output with score 9, due to 1 binary in the local folder.

I did added Environment variable for SARIF format as well as "ENABLE_SARIF":"1", however, I am getting below error while generating SARIF format:
"error during command execution: failed to format results: failed to output results: internal error: missing policy for check: Binary-Artifacts"

I have below 2 questions:

  1. Is it fine to change checks/binary_artifact.go by adding FileBased in init(), this indirectly fails the tests in policy_test.go? Can we update it? So that the scorecard tool can be used for local folder Binary Artifact Detection
  2. Any inputs regarding when will the SARIF format be supported in command line? I am trying to add environment variables and run the tool, however i get policy missing error as mentioned above. Is there any way to achieve this pelase?

Thanks in advance,

Shilpa

@shilpaworld shilpaworld added the kind/bug Something isn't working label Jul 10, 2023
@spencerschrock
Copy link
Contributor

Hmm, I'm wondering if we can add support locally if we handle the error from ListSuccessfulWorkflowRuns in the locally client gracefully. This may also apply to GitLab @raghavkaul .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check/Binary-Artifacts kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants