Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Skip .git folder in localdir client #3908

Closed
pnacht opened this issue Mar 1, 2024 · 0 comments · Fixed by #3943
Closed

Feature: Skip .git folder in localdir client #3908

pnacht opened this issue Mar 1, 2024 · 0 comments · Fixed by #3943
Assignees
Labels
good first issue Good for newcomers kind/enhancement New feature or request

Comments

@pnacht
Copy link
Contributor

pnacht commented Mar 1, 2024

Is your feature request related to a problem? Please describe.
The localdir client currently runs through the repository's .git folder. This is a common folder which may (in rare cases) include many (or large, or many large) files which are irrelevant to Scorecard's analysis. Indeed, the issue in #3831 caused Scorecard to crash even when the "visible" large files were deleted.

Describe the solution you'd like
The localdir client simply skips the .git directory entirely.

Describe alternatives you've considered
With the changes @spencerschrock suggested in #3831 (comment), this may no longer be necessary to avoid crashing due to large "hidden" files, so this can simply be ignored once those changes have been made.

But the .git folder can still contain many files, which could slow Scorecard down by their sheer number.

@pnacht pnacht added the kind/enhancement New feature or request label Mar 1, 2024
@spencerschrock spencerschrock added the good first issue Good for newcomers label Mar 6, 2024
@naveensrinivasan naveensrinivasan self-assigned this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants