-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Patch Maintainers Annotations #4048
Comments
Related to: #1907 |
We should not pass
I think this should be all-or-nothing: maintainers should validate the annotation file by running scorecard on their repo locally before committing it. Closing. When might a valid annotation file become invalid over time?
Neither of these cases is typical. |
Based on this comment, I think the runs field should continue to be populated: Lines 644 to 649 in 9cd1fb8
|
Describe the bug
Some things still need to be addressed in Maintainers Annotation feature (regarding PR #3905):
scorecard/config/config.go
Lines 28 to 31 in 19f8ae1
runs
. Or, if is working as expected and we should not populateruns
if there are no relevantresults
for that check ( ⚠️ Add initial Maintainers Annotation parsing #3905 (comment)).scorecard/config/config.go
Lines 73 to 74 in 19f8ae1
scorecard/config/config_test.go
Lines 134 to 138 in 19f8ae1
scorecard/pkg/json.go
Lines 131 to 134 in 19f8ae1
.scorecard.yml
,.github/.scorecard.yml
, ...)The text was updated successfully, but these errors were encountered: