Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New kernel file interface polling interface for Linux 4.18 (io_uring)? #3558

Closed
oowl opened this issue May 29, 2023 · 3 comments
Closed

New kernel file interface polling interface for Linux 4.18 (io_uring)? #3558

oowl opened this issue May 29, 2023 · 3 comments
Assignees
Labels
EnglishNative This issue is conveyed exclusively in English. Won't fix We won't fix it.

Comments

@oowl
Copy link

oowl commented May 29, 2023

Note: Please read FAQ before file an issue, see #2716

Description

Please description your issue here

Would SRS(ST-fork) be supported io_uring poll interface for file IO, I believe this will benefit the overall file IO performance and system stability of SRS (because SRS is a single-threaded program without any other threads to handle read/write operations for recorded files, and file IO itself is blocking in the existing system of SRS).

@oowl
Copy link
Author

oowl commented May 29, 2023

#2188

This is also another solution for SRS in addressing this problem. Implementing multi-threading support for the entire SRS could be complicated, but adding support for io_uring may be a feasible and quick solution for the st.

@oowl
Copy link
Author

oowl commented May 29, 2023

For example, we can see libuv io_uring patch libuv/libuv#3952, it's small change (in code lines number change side)

@winlinvip
Copy link
Member

winlinvip commented Jun 4, 2023

Yes, we have plans to incorporate io_uring support into ST and would welcome any patches or contributions towards this effort.

To request support for io_uring in ST, please submit an issue on https://github.com/ossrs/state-threads

@winlinvip winlinvip closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2023
@winlinvip winlinvip self-assigned this Jun 4, 2023
@winlinvip winlinvip added the Won't fix We won't fix it. label Jun 4, 2023
@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EnglishNative This issue is conveyed exclusively in English. Won't fix We won't fix it.
Projects
None yet
Development

No branches or pull requests

2 participants