Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fd leak when fork: forgot to set FD_CLOEXEC for the fd received from accept #518

Closed
YueHonghui opened this issue Nov 3, 2015 · 3 comments
Closed

fd leak when fork: forgot to set FD_CLOEXEC for the fd received from accept #518

YueHonghui opened this issue Nov 3, 2015 · 3 comments
Assignees
@winlinvip
Labels
Bug It might be a bug. TransByAI Translated by AI/GPT.
Milestone
2.0

Comments

@YueHonghui
Copy link
Contributor

YueHonghui commented Nov 3, 2015 •
edited by winlinvip
Loading

Forgot to set FD_CLOEXEC for the accepted fd, which will result in fd leakage when FORK FFMPEG.

TRANS_BY_GPT3
@winlinvip winlinvip added the Bug It might be a bug. label Nov 3, 2015
@winlinvip winlinvip added this to the srs 2.0 release milestone Nov 3, 2015
@winlinvip
Copy link
Member

winlinvip commented Nov 3, 2015 •
edited
Loading

Can I submit a patch? git format-patch origin/develop will do, I haven't looked at this ioctl for a long time.

TRANS_BY_GPT3

@YueHonghui
Copy link
Contributor Author

YueHonghui commented Nov 16, 2015 •
edited by winlinvip
Loading

Submitting a patch won't... Does submitting a PR work?

TRANS_BY_GPT3

@winlinvip
Copy link
Member

winlinvip commented Nov 16, 2015 •
edited
Loading

PR is better than patch, haha.
😄

TRANS_BY_GPT3

@winlinvip winlinvip mentioned this issue Nov 16, 2015
Merged
@winlinvip winlinvip changed the title accept上来的fd忘了设置FD_CLOEXEC fd leak: accept上来的fd忘了设置FD_CLOEXEC Nov 16, 2015
@winlinvip winlinvip changed the title fd leak: accept上来的fd忘了设置FD_CLOEXEC fd leak when fork: accept上来的fd忘了设置FD_CLOEXEC Nov 16, 2015
@winlinvip winlinvip self-assigned this Sep 25, 2021
@winlinvip winlinvip changed the title fd leak when fork: accept上来的fd忘了设置FD_CLOEXEC fd leak when fork: forgot to set FD_CLOEXEC for the fd received from accept Jul 28, 2023
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@winlinvip winlinvip

Labels
Bug It might be a bug. TransByAI Translated by AI/GPT.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@winlinvip @YueHonghui