Skip to content

Commit

Permalink
core: Set mtime of content objects to 0
Browse files Browse the repository at this point in the history
This is necessary to satisfy tools such as guile and python, which
compare mtimes to determine whether or not source files need to be
compiled.

https://bugzilla.gnome.org/show_bug.cgi?id=720363
  • Loading branch information
Roddy Shuler authored and cgwalters committed Dec 15, 2013
1 parent 38a286f commit fe5ed36
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 0 deletions.
18 changes: 18 additions & 0 deletions src/libostree/ostree-repo-commit.c
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ commit_loose_object_trusted (OstreeRepo *self,
{
int fd;
int res;
struct timespec times[2];

g_assert (temp_out != NULL);

Expand Down Expand Up @@ -134,6 +135,23 @@ commit_loose_object_trusted (OstreeRepo *self,
if (!gs_fd_set_all_xattrs (fd, xattrs, cancellable, error))
goto out;
}

/* To satisfy tools such as guile which compare mtimes
* to determine whether or not source files need to be compiled,
* set the modification time to 0.
*/
times[0].tv_sec = 0; /* atime */
times[0].tv_nsec = UTIME_OMIT;
times[1].tv_sec = 0; /* mtime */
times[1].tv_nsec = 0;
do
res = futimens (fd, times);
while (G_UNLIKELY (res == -1 && errno == EINTR));
if (G_UNLIKELY (res == -1))
{
ot_util_set_error_from_errno (error, errno);
goto out;
}
}

/* Ensure that in case of a power cut, these files have the data we
Expand Down
7 changes: 7 additions & 0 deletions tests/test-basic.sh
Original file line number Diff line number Diff line change
Expand Up @@ -310,3 +310,10 @@ ${CMD_PREFIX} ostree --repo=repo remote show-url aremote > aremote-url.txt
assert_file_has_content aremote-url.txt 'http.*remote\.example\.com/repo'
echo "ok remote show-url"

cd ${test_tmpdir}
rm -rf test2-checkout
$OSTREE checkout test2 test2-checkout
stat '--format=%Y' test2-checkout/baz/cow > cow-mtime
assert_file_has_content cow-mtime 0
echo "ok content mtime"

0 comments on commit fe5ed36

Please sign in to comment.