Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rofiles-fuse: does not compile with musl (v2024.4) #3200

Closed
YukariChiba opened this issue Feb 26, 2024 · 3 comments
Closed

rofiles-fuse: does not compile with musl (v2024.4) #3200

YukariChiba opened this issue Feb 26, 2024 · 3 comments
Labels
area/rofiles-fuse Issues for rofiles-fuse (soft deprecated) difficulty/low Not extremely difficult reward/medium Fixing this will be notably useful

Comments

@YukariChiba
Copy link

I noticed that 4d95848 introduced statx which is not supported by musl.

To reproduce, compile ostree v2024.4 with any musl-based distro (e.g, alpine).

@cgwalters cgwalters added area/rofiles-fuse Issues for rofiles-fuse (soft deprecated) reward/medium Fixing this will be notably useful difficulty/low Not extremely difficult labels Feb 26, 2024
@cgwalters
Copy link
Member

Hmm, messy. I wonder if musl users care about rofiles-fuse? Hmm, looks like flatpak-builder uses it.

Well, this is a bit painful as the code is significantly cleaner with statx...

And OK wow, where is the issue tracker for musl? (OK, some digging through the mail-archives-as-bug-tracker leads to https://www.openwall.com/lists/musl/2020/01/19/7 so we're hardly the first to hit this pain)

@cgwalters
Copy link
Member

Per https://lwn.net/Articles/964181/

On February 29, the musl project announced release 1.2.5, including support for loongarch64 and riscv32. This release also contains support for the statx(), preadv2(), and pwritev2() system calls.

So...dunno. I guess my inclination here is to recommend that musl users carry a downstream patch to revert the commits in #3175
until such time as they can update to the new musl.

And I guess we need to add a CI job here that covers alpine.

@YukariChiba
Copy link
Author

It's been a while since musl 1.2.5 was released. It's basically a non-issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rofiles-fuse Issues for rofiles-fuse (soft deprecated) difficulty/low Not extremely difficult reward/medium Fixing this will be notably useful
Projects
None yet
Development

No branches or pull requests

2 participants