Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA for conda-forge? #224

Closed
jGaboardi opened this issue Apr 23, 2020 · 5 comments
Closed

GHA for conda-forge? #224

jGaboardi opened this issue Apr 23, 2020 · 5 comments

Comments

@jGaboardi
Copy link
Member

@knaaptime Awesome job the last few days getting the PyPI upload GHA working. I am curious how this will affect the re-up of conda-forge versioning. Specifically, (1) will the conda-forge bot continue making automated PRs if the feedstock version doesn't match the PyPI version; and (2) will (could?) a new GHA be created to accomplish this.

@knaaptime
Copy link
Member

i think the answer to 1 is yes, i'd expect the condabot to still keep pinging recipe maintiners each time a new pypi release gets pushed. 2 would be pretty interesting though. That would remove the need to double check the dependency changes each time (which can be a real pain)

@knaaptime
Copy link
Member

p.s., the only stuff i'm tinkering with now is very geosnap-specific, so we should probably start copying over the base logic to the submod template

@jGaboardi
Copy link
Member Author

It would be super neat to have that as a jobs.<job_id>.needs following the PyPI publishing in the same workflow.

@knaaptime
Copy link
Member

should we close this given the new auto-merge functionality in conda-forge?

@jGaboardi
Copy link
Member Author

Yup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants