AO3-5744 Fix following relative redirects in work importing #4861
+26
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjaustin
approved these changes
Jul 10, 2024
Bilka2
added
the
Temporarily Closed
Bilka2
removed
the
Temporarily Closed
Bilka2
added
the
Temporarily Closed
Bilka2
removed
the
Temporarily Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-5744
Purpose
Handle relative redirects in work importing by using the original request host for relative redirect targets instead of trying to directly go to a target like
/856.html.Testing Instructions
More candidate URLs for testing are multichapter works on AO3 because they do a relative redirect to the first chapter. E.g. https://archiveofourown.org/works/1153569 redirects to /works/1153569/chapters/2339203
Credit
Bilka (he/him)