Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bin entrypoint #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

youaresofunny
Copy link

@youaresofunny youaresofunny commented Aug 17, 2020

Description

Fixes wrong bin path in package.json

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@youaresofunny
Copy link
Author

Commit that broke it:
9e82cb8

@cspotcode
Copy link

Is there anything else we need to do for this to be merged and released?

@cspotcode
Copy link

For reference: fixes #19 and probably #18

@cspotcode
Copy link

I have made this fix and published a forked version to @cspotcode/opendocumenter: https://www.npmjs.com/package/@cspotcode/opendocumenter

@cspotcode
Copy link

Should we leave this open since the issue is still not fixed?

@R4wizard
Copy link
Member

R4wizard commented Jan 27, 2021

Should we leave this open since the issue is still not fixed?

Yup, this should've been left open. I mostly glance over the dependabot MRs as I'm quite busy right now.
I'm going to reopen this and work on the project. a little over the next couple of weeks

@R4wizard R4wizard reopened this Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants