Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create before destroy node pool #36

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Conversation

alexouzounis
Copy link
Member

Signed-off-by: Alex Ouzounis alex@ouzi.dev

Signed-off-by: Alex Ouzounis <alex@ouzi.dev>
@ouzibot ouzibot requested review from belitre and givanov July 20, 2020 09:35
@ouzibot ouzibot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 20, 2020
@givanov
Copy link
Member

givanov commented Jul 20, 2020

/lgtm

@ouzibot ouzibot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2020
@ouzibot
Copy link

ouzibot commented Jul 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexouzounis, givanov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexouzounis,givanov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ouzibot ouzibot merged commit a9f65f2 into master Jul 20, 2020
@ouzibot ouzibot deleted the feat/create_before_destroy branch July 20, 2020 09:37
@ouzibot
Copy link

ouzibot commented Jul 20, 2020

This pull request is included in version 0.12.0

@ouzibot ouzibot added the released Denotes a PR that was already included in a release label Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. released Denotes a PR that was already included in a release size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants