Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node:http has missing ref/unref functions #2524

Closed
krutoo opened this issue Mar 31, 2023 · 2 comments · Fixed by #8675
Closed

node:http has missing ref/unref functions #2524

krutoo opened this issue Mar 31, 2023 · 2 comments · Fixed by #8675
Labels
bug Something isn't working node.js Compatibility with Node.js APIs

Comments

@krutoo
Copy link

krutoo commented Mar 31, 2023

What version of Bun is running?

0.5.8

What platform is your computer?

Darwin 22.1.0 arm64 arm

What steps can reproduce the bug?

Here's an example that shows Bun does not implement the ref and unref functions:
https://github.com/krutoo/bun-opentelemetry

According to @Jarred-Sumner on discord we ned to implement this functions:
https://discord.com/channels/876711213126520882/1091280232025182239/1091376674425274499

What is the expected behavior?

Bun should implement ref/unref functions of http module

What do you see instead?

Bun now not implemented ref/unref functions of http module

Additional information

No response

@krutoo
Copy link
Author

krutoo commented May 22, 2023

looks like docs contain incorrect information about node:http module according this issue
https://bun.sh/docs/runtime/nodejs-apis

@JuroOravec
Copy link

Came across this while trying to run Crawlee/Apify (web scraping framework) via Bun (See discussion apify/proxy-chain#521). This and the missing fs.opendir are blocking the adoption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working node.js Compatibility with Node.js APIs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants