Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement performance.mark(), performance.measure() #3790

Closed
birkskyum opened this issue Jul 24, 2023 · 6 comments
Closed

Implement performance.mark(), performance.measure() #3790

birkskyum opened this issue Jul 24, 2023 · 6 comments
Labels
bug Something isn't working web-api Something that relates to a standard Web API

Comments

@birkskyum
Copy link
Collaborator

birkskyum commented Jul 24, 2023

These api's aren't implemented in Bun.

This is partially implemented, performance.now() exists but not performance.mark(), performance.measure(), nor the other Node-specific functions (they throw a not implemented error)

@birkskyum birkskyum added the bug Something isn't working label Jul 24, 2023
@robobun robobun added the web-api Something that relates to a standard Web API label Jul 24, 2023
@birkskyum
Copy link
Collaborator Author

Apparently Jest rely on this as well

@Jordan-Hall
Copy link

@paperdave this is the last major barrier for NX, Any chance we can stub this. I'm not good with bun internal so wouldn't know where to start :( Stubbing this will help with a few libraries i believe

@paperdave
Copy link
Member

can you retry on canary. these methods already were stubbed I think.

@Jordan-Hall
Copy link

@paperdave THANK YOU. It's worked no more patching NX, with a custom runner #3786 is now supported

@ImLunaHey
Copy link
Contributor

next returns NaN because of this 😅

➜  watcher git:(main) bun --revision
1.0.18+a648ed9e6
➜  watcher git:(main) bun --bun next dev
   ▲ Next.js 14.0.4
   - Local:        http://localhost:3000

 ✓ Ready in NaNms
 ○ Compiling / ...
 ✓ Compiled / in 1022ms (491 modules)
 ✓ Compiled in 752ms (235 modules)
^C
                                                                                                                                                                      
➜  watcher git:(main) bun --node next dev
   ▲ Next.js 14.0.4
   - Local:        http://localhost:3000

 ✓ Ready in 2.2s
 ○ Compiling / ...
 ✓ Compiled / in 619ms (491 modules)
 ✓ Compiled in 109ms (235 modules)
^C

@birkskyum
Copy link
Collaborator Author

Believe this is closed by

Duplicate issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working web-api Something that relates to a standard Web API
Projects
None yet
Development

No branches or pull requests

5 participants