Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sveltekit is very slow in bun when running with @sveltejs/adapter-node #8637

Closed
huseeiin opened this issue Feb 2, 2024 · 1 comment
Closed
Labels
performance An issue with performance

Comments

@huseeiin
Copy link
Contributor

huseeiin commented Feb 2, 2024

What is the problem this feature would solve?

a full reproduction with details: https://github.com/huseeiin/bun-svelte-adapter-node
benchmarks done with oha:
oha -n 10000 http://localhost:3000
about 2800 req/s

What is the feature you are proposing to solve the problem?

either the bun or svelte team to build a stable bun adapter for sveltekit since its very hard to build a fully-fledged production-ready one especially that the maintainer of svelte-adapter-bun is one person.

What alternatives have you considered?

i built a small bun adapter in the repo above. it doesn't work for all needs but it gives hope 😄

@huseeiin huseeiin added the enhancement New feature or request label Feb 2, 2024
@Electroid Electroid added performance An issue with performance and removed enhancement New feature or request labels Feb 2, 2024
@Jarred-Sumner
Copy link
Collaborator

Jarred-Sumner commented Mar 3, 2024

from the readme:

adapter-node with bun: ~2800 req/s
adapter-node with node: ~1400 req/s

Considering we're 2x faster than node here, it sounds likely this is something for SvelteKit to investigate rather than for us to take action on (which would benefit in all runtimes). I think it's worth looking at in the future but I don't think this is something we're likely to take action on soon.

@Jarred-Sumner Jarred-Sumner closed this as not planned Won't fix, can't repro, duplicate, stale Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance An issue with performance
Projects
None yet
Development

No branches or pull requests

3 participants