Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: set default for name in ErrorCode.ts #15699

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

DonIsaac
Copy link
Contributor

What does this PR do?

When no name is provided, constructor.name is used. Affects generated error
code files.

How did you verify your code works?

This is a build change. If this code compiles, it works.

@robobun
Copy link

robobun commented Dec 11, 2024

❌ Your commit 5905fd3 has 13 failures in #7764:

  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 20.04 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64
  • test/js/third_party/jsonwebtoken/async_sign.test.js - 1 failing on 🐧 20.04 x64-baseline
  • test/js/bun/css/doesnt_crash.test.ts - timeout on 🐧 12 aarch64
  • test/js/bun/css/doesnt_crash.test.ts - timeout on 🐧 3.20 aarch64
  • test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 22.04 aarch64
  • test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 22.04 x64
  • test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 24.04 x64-baseline
  • test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 12 x64-baseline
  • test/js/deno/performance/performance.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/deno/performance/performance.test.ts - 1 failing on 🐧 24.04 x64-baseline
  • test/bundler/bundler_compile.test.ts - 3 failing on 🐧 22.04 aarch64
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 24.04 aarch64
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 aarch64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 x64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 x64-baseline
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 aarch64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 x64
  • test/js/node/fs/fs.test.ts - timeout on 🪟 2019 x64-baseline
  • test/js/node/test/parallel/test-fs-readfile-flags.js - code 1 on 🪟 2019 x64
  • test/js/node/test/parallel/test-fs-readfile-flags.js - code 1 on 🪟 2019 x64-baseline
  • test/js/node/watch/fs.watchFile.test.ts - 1 failing on 🪟 2019 x64-baseline
  • test/js/node/test/parallel/test-fs-watch-file-enoent-after-deletion.js - internal assertion failure on 🪟 2019 x64
  • test/js/node/test/parallel/test-fs-watch-file-enoent-after-deletion.js - internal assertion failure on 🪟 2019 x64-baseline
  • @Jarred-Sumner Jarred-Sumner merged commit 78445c5 into main Dec 11, 2024
    61 checks passed
    @Jarred-Sumner Jarred-Sumner deleted the don/refactor/gen-err-code-name branch December 11, 2024 09:08
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants