-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Next.js Pages Router to work #6095
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarred-Sumner
approved these changes
Sep 27, 2023
-webkit needs to not change |
paperdave
force-pushed
the
dave/integration-test
branch
from
September 27, 2023 05:39
50c8615
to
a36d2c2
Compare
test failures:
|
Jarred-Sumner
requested changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can’t merge until tests pass
paperdave
changed the title
fix next pages router + integration test
Fix Next.js App+Pages Router
Sep 27, 2023
paperdave
changed the title
Fix Next.js App+Pages Router
Get Next.js Pages Router to work
Sep 27, 2023
paperdave
force-pushed
the
dave/integration-test
branch
from
September 28, 2023 06:56
d9989ef
to
123012d
Compare
This was referenced Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
also does asyncLocalStorage.bind also does tty fixes for inquirer also adds an assert that will fail when using next.js but its only a dev one
How did you verify your code works?
because i said so