Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Next.js Pages Router to work #6095

Merged
merged 15 commits into from
Sep 28, 2023
Merged

Get Next.js Pages Router to work #6095

merged 15 commits into from
Sep 28, 2023

Conversation

paperdave
Copy link
Member

What does this PR do?

also does asyncLocalStorage.bind also does tty fixes for inquirer also adds an assert that will fail when using next.js but its only a dev one

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

because i said so

@Jarred-Sumner
Copy link
Collaborator

-webkit needs to not change
-launch.json changes are prob unintentional

@Jarred-Sumner
Copy link
Collaborator

@paperdave

test failures:

  • test/integration/next/default-pages-dir/test/dev-server.test.ts
  • test/js/node/process/process-stdio.test.ts
  • test/js/node/stream/node-stream.test.js

Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can’t merge until tests pass

@paperdave paperdave changed the title fix next pages router + integration test Fix Next.js App+Pages Router Sep 27, 2023
@paperdave paperdave changed the title Fix Next.js App+Pages Router Get Next.js Pages Router to work Sep 27, 2023
@Jarred-Sumner Jarred-Sumner merged commit 387f126 into main Sep 28, 2023
16 of 21 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dave/integration-test branch September 28, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants