Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manager-components): add guide onclick callback #13859

Open
wants to merge 1 commit into
base: maintenance/manager-react-components-v1.x
Choose a base branch
from
Open

fix(manager-components): add guide onclick callback #13859

wants to merge 1 commit into from
+2 −0

Conversation

rjamet-ovh
Copy link
Contributor

Question Answer
Branch? develop
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #ISSUE-13845
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

fix(manager-components): add guide onclick callback
f88b753 
ref:ISSUE-13845

Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
@rjamet-ovh rjamet-ovh requested review from a team as code owners October 30, 2024 15:06
@github-actions github-actions bot added the bug Something isn't working label Oct 30, 2024
@rjamet-ovh rjamet-ovh linked an issue Oct 30, 2024 that may be closed by this pull request
[manager-components]: add missing onClick callback on guideButton #13845
Open
3 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

SimonChaumet
SimonChaumet previously approved these changes Oct 30, 2024
View reviewed changes
stif59100
stif59100 previously approved these changes Oct 30, 2024
View reviewed changes
fredericvilcot
fredericvilcot previously approved these changes Oct 30, 2024
View reviewed changes
tristanwagner
tristanwagner previously approved these changes Oct 30, 2024
View reviewed changes
anooparveti
anooparveti previously approved these changes Nov 12, 2024
View reviewed changes
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 13, 2024
@rjamet-ovh rjamet-ovh changed the base branch from develop to maintenance/manager-react-components-v1.x November 14, 2024 10:46
@rjamet-ovh rjamet-ovh dismissed stale reviews from anooparveti, tristanwagner, fredericvilcot, stif59100, and SimonChaumet November 14, 2024 10:46

The base branch was changed.

@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericvilcot fredericvilcot fredericvilcot left review comments

@stif59100 stif59100 stif59100 left review comments

@anooparveti anooparveti anooparveti left review comments

@tristanwagner tristanwagner tristanwagner left review comments

@SimonChaumet SimonChaumet SimonChaumet left review comments

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[manager-components]: add missing onClick callback on guideButton
6 participants
@rjamet-ovh @SimonChaumet @tristanwagner @anooparveti @fredericvilcot @stif59100