Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(httpExecutor): support changing request hostname #217

Closed
titpetric opened this issue Jan 20, 2020 · 0 comments · Fixed by #218
Closed

bug(httpExecutor): support changing request hostname #217

titpetric opened this issue Jan 20, 2020 · 0 comments · Fixed by #218

Comments

@titpetric
Copy link
Contributor

When building a http request in Go, the Host header isn't honored. From the docs:

	// For client requests Host optionally overrides the Host
	// header to send. If empty, the Request.Write method uses
	// the value of URL.Host.
	Host string		Host string

I'd still expect the Host being set in the executor Headers, adding a check for it and setting req.Host respectively.

@titpetric titpetric changed the title feat(httpExecutor): support changing request hostname bug(httpExecutor): support changing request hostname Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant