fix: TestSuiteXML is missing the Time property #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Value is converted from float64 to string. This will resolve gh actions test reporters for junit xml, showing missing test suite time execution values Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
ivan-velasco
force-pushed
the
fix/junit_testsuite_time
branch
from
867fbbf
to
d75362b
Compare
|
LGTM - Notice that ts.Duration contains value in Seconds, not ms. |
yesnault
approved these changes
Feb 14, 2023
ivan-velasco
added a commit
to socotra/venom
that referenced
this pull request
Sep 20, 2023
Value is converted from float64 to string. This will resolve gh actions test reporters for junit xml, showing missing test suite time execution values Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value is converted from float64 to string. This will resolve gh actions test reporters for junit xml, showing missing test suite time execution values