-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: removed result from testcase variables and removed errors warning and info from non verbose runs #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDS Report build-venom-a#47.0 ✘
|
CDS Report build-venom-a#48.0 ✘
|
Hey @yesnault, PR is ready, tests were updated and I checked the latest CDS run, modified the last commits to fix the last failing test. |
…ue in teststep and show info before errors Signed-off-by: kpaquier <kilian.paquier.ext@ovhcloud.com>
Signed-off-by: kpaquier <kilian.paquier.ext@ovhcloud.com>
Signed-off-by: kpaquier <kilian.paquier.ext@ovhcloud.com>
Signed-off-by: kpaquier <kilian.paquier.ext@ovhcloud.com>
LGTM, thank you @kilianpaquier |
yesnault
approved these changes
May 31, 2023
Begi
pushed a commit
to intercloud/venom
that referenced
this pull request
Jun 15, 2023
…ng and info from non verbose runs (ovh#670) * feat: remove tc computedInfo, fix info not showing right variable value in teststep and show info before errors * feat: removed ranged stdout on non-verbose runs * fix: update failing tests following breaking change * chore: review README according to latest change Signed-off-by: kpaquier <kilian.paquier.ext@ovhcloud.com>
ivan-velasco
pushed a commit
to socotra/venom
that referenced
this pull request
Jun 22, 2023
…ng and info from non verbose runs (ovh#670) * feat: remove tc computedInfo, fix info not showing right variable value in teststep and show info before errors * feat: removed ranged stdout on non-verbose runs * fix: update failing tests following breaking change * chore: review README according to latest change Signed-off-by: kpaquier <kilian.paquier.ext@ovhcloud.com> Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
ivan-velasco
pushed a commit
to socotra/venom
that referenced
this pull request
Sep 20, 2023
…ng and info from non verbose runs (ovh#670) * feat: remove tc computedInfo, fix info not showing right variable value in teststep and show info before errors * feat: removed ranged stdout on non-verbose runs * fix: update failing tests following breaking change * chore: review README according to latest change Signed-off-by: kpaquier <kilian.paquier.ext@ovhcloud.com> Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey ! Following our discussion this afternoon on this old comment #617 (comment), I've remade the PR with current master.