Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed result from testcase variables and removed errors warning and info from non verbose runs #670

Merged
merged 4 commits into from
May 31, 2023

Conversation

kilianpaquier
Copy link
Contributor

@kilianpaquier kilianpaquier commented May 22, 2023

Hey ! Following our discussion this afternoon on this old comment #617 (comment), I've remade the PR with current master.

  • removed ranged prints on non-verbose runs
  • fixed info not interpolating right variable in step X with .result variable (was showing variable from X-1)
  • print info before errors: closes Print info in current "step" before assertions #597
  • on non-verbose runs, print info only when there're failures

@ovh-cds
Copy link
Collaborator

ovh-cds commented May 22, 2023

CDS Report build-venom-a#47.0 ✘

  • Build
    • Build ✔
    • Unit Tests ✔
  • Tests
    • Acceptance Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented May 23, 2023

CDS Report build-venom-a#48.0 ✘

  • Build
    • Build ✔
    • Unit Tests ✔
  • Tests
    • Acceptance Tests ✘

@kilianpaquier kilianpaquier marked this pull request as ready for review May 23, 2023 09:45
@kilianpaquier
Copy link
Contributor Author

Hey @yesnault, PR is ready, tests were updated and I checked the latest CDS run, modified the last commits to fix the last failing test.

kpaquier added 4 commits May 23, 2023 09:50
…ue in teststep and show info before errors

Signed-off-by: kpaquier <kilian.paquier.ext@ovhcloud.com>
Signed-off-by: kpaquier <kilian.paquier.ext@ovhcloud.com>
Signed-off-by: kpaquier <kilian.paquier.ext@ovhcloud.com>
Signed-off-by: kpaquier <kilian.paquier.ext@ovhcloud.com>
@yesnault
Copy link
Member

LGTM, thank you @kilianpaquier

@yesnault yesnault merged commit 0b4842d into ovh:master May 31, 2023
Begi pushed a commit to intercloud/venom that referenced this pull request Jun 15, 2023
…ng and info from non verbose runs (ovh#670)

* feat: remove tc computedInfo, fix info not showing right variable value in teststep and show info before errors
* feat: removed ranged stdout on non-verbose runs
* fix: update failing tests following breaking change
* chore: review README according to latest change

Signed-off-by: kpaquier <kilian.paquier.ext@ovhcloud.com>
ivan-velasco pushed a commit to socotra/venom that referenced this pull request Jun 22, 2023
…ng and info from non verbose runs (ovh#670)

* feat: remove tc computedInfo, fix info not showing right variable value in teststep and show info before errors
* feat: removed ranged stdout on non-verbose runs
* fix: update failing tests following breaking change
* chore: review README according to latest change

Signed-off-by: kpaquier <kilian.paquier.ext@ovhcloud.com>
Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
ivan-velasco pushed a commit to socotra/venom that referenced this pull request Sep 20, 2023
…ng and info from non verbose runs (ovh#670)

* feat: remove tc computedInfo, fix info not showing right variable value in teststep and show info before errors
* feat: removed ranged stdout on non-verbose runs
* fix: update failing tests following breaking change
* chore: review README according to latest change

Signed-off-by: kpaquier <kilian.paquier.ext@ovhcloud.com>
Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
@kilianpaquier kilianpaquier deleted the fix-infos branch October 29, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print info in current "step" before assertions
3 participants