fix(venom): env variables with equal sign #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesnault
requested changes
Sep 27, 2023
There was a problem hiding this comment.
Hi @bramca , thank you for your proposal.
Can you add a unit test about that into https://github.com/ovh/venom/blob/master/cmd/venom/run/cmd_test.go#L92 please?
added 2 commits
September 28, 2023 09:45
Signed-off-by: Bram.Cautaerts <bram.cautaerts@ing.com>
Signed-off-by: Bram.Cautaerts <bram.cautaerts@ing.com>
|
Added a unit test for it |
yesnault
requested changes
Sep 28, 2023
cmd/venom/run/cmd.go
Outdated
| @@ -289,7 +289,7 @@ func initFromEnv(environ []string) ([]string, error) { | |||
| if strings.HasPrefix(env, "VENOM_VAR_") { | |||
| tuple := strings.Split(env, "=") | |||
There was a problem hiding this comment.
Suggested change
| tuple := strings.Split(env, "=") | |
| tuple := strings.SplitN(a, "=", 2) |
There was a problem hiding this comment.
agreed, good suggestion
Signed-off-by: Bram.Cautaerts <bram.cautaerts@ing.com>
|
LGTM, thank you |
yesnault
approved these changes
Sep 28, 2023
yesnault
changed the title
yesnault
changed the title
fsamin
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issue:
VENOM_VAR_a='host=localhost'
results in a='host' because of the split on '=' and only taking the first value back
With this the var would end up like this:
a = 'host=localhost'
Making it possible to add equal signs in the variable