Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for scrollToTap #137

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add option for scrollToTap #137

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9b86ad
Option to disable scroll tap outside
karneaud Aug 16, 2022
9d944b4
Add property option to allow scroll to tap
karneaud Aug 16, 2022
0e1abb8
Add default option scrollToTap
karneaud Aug 16, 2022
392c07b
Update modifications
karneaud Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/dragdealer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ var Dragdealer = function(wrapper, options) {
*
* - number right=0: Right padding between the wrapper and the handle.
*
* - bool scrollToTap=true: Option to only allow movement on handle drag.
*
* - fn callback(x, y): Called when releasing handle, with the projected
* x, y position of the handle. Projected value means
* the value the slider will have after finishing a
Expand Down Expand Up @@ -227,6 +229,7 @@ Dragdealer.prototype = {
snap: false,
loose: false,
speed: 0.1,
scrollToTap: true,
xPrecision: 0,
yPrecision: 0,
handleClass: 'handle',
Expand Down Expand Up @@ -410,7 +413,7 @@ Dragdealer.prototype = {
this.startDrag();
},
onHandleTouchStart: function(e) {
Cursor.refresh(e);
Cursor.refresh(e);
// Unlike in the `mousedown` event handler, we don't prevent defaults here,
// because this would disable the dragging altogether. Instead, we prevent
// it in the `touchmove` handler. Read more about touch events
Expand All @@ -433,6 +436,9 @@ Dragdealer.prototype = {
}
},
onWrapperTouchMove: function(e) {
if (!this.options.scrollToTap && (e.target != this.handle && e.target != this.wrapper) ) {
return;
}
Cursor.refresh(e);
// Dragging on a disabled axis (horizontal or vertical) shouldn't prevent
// defaults on touch devices. !this.activity denotes this is the first move
Expand All @@ -451,11 +457,15 @@ Dragdealer.prototype = {
},
onWrapperMouseDown: function(e) {
Cursor.refresh(e);
preventEventDefaults(e);
this.startTap();
preventEventDefaults(e);
this.startTap();
},
onWrapperTouchStart: function(e) {
Cursor.refresh(e);
if (!this.options.scrollToTap && (e.target != this.handle && e.target != this.wrapper) ) {
return;
}

Cursor.refresh(e);
preventEventDefaults(e);
this.startTap();
},
Expand Down