Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag & Drop: workflow with task having no position #613

Open
chloegugli opened this issue Oct 30, 2018 · 1 comment
Open

Drag & Drop: workflow with task having no position #613

chloegugli opened this issue Oct 30, 2018 · 1 comment

Comments

@chloegugli
Copy link
Contributor

chloegugli commented Oct 30, 2018

When we drag and drop a workflow that has tasks with position (metadata > positionTop/positionLeft tags) and tasks without position, an error occurs and the workflow isn't imported.
What happens is that in layoutNewElements function (Workflow view), we draw a graph of tasks that don't have positions. If a task has a position, we don't add it to this graph but some tasks might depend on it. This makes incoherent graph that can't be drawn (error when calling : dagre.layout().nodes(nodes).edges(edges).nodeSep(50).rankSep(100).run())
I tried adding a loop to check if one task doesn't have a position we add all the tasks in the loop (cf file joined) but this has side effects: as it loops through all tasks, the ones that are already in the studio (workflow designer) are re-positioned.

@chloegugli
Copy link
Contributor Author

WorkflowView.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant