From d1488269976867104c5413b17b08aa48103a157a Mon Sep 17 00:00:00 2001
From: Daniel Bachler <daniel@danielbachler.de>
Date: Thu, 30 Jan 2025 22:28:40 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A8=20incorporate=20PR=20feedback?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../grapher/src/core/LegacyToOwidTable.ts         | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/packages/@ourworldindata/grapher/src/core/LegacyToOwidTable.ts b/packages/@ourworldindata/grapher/src/core/LegacyToOwidTable.ts
index 20836a136f..cde6503843 100644
--- a/packages/@ourworldindata/grapher/src/core/LegacyToOwidTable.ts
+++ b/packages/@ourworldindata/grapher/src/core/LegacyToOwidTable.ts
@@ -8,9 +8,9 @@ import {
     OwidColumnDef,
     OwidVariableDimensions,
     OwidVariableDataMetadataDimensions,
-    EntityId,
     ErrorValue,
     OwidChartDimensionInterfaceWithMandatorySlug,
+    EntityName,
 } from "@ourworldindata/types"
 import {
     OwidTable,
@@ -332,20 +332,19 @@ export const legacyToOwidTableAndDimensions = (
         const entityColorColumnSlug = OwidTableSlugs.entityColor
 
         const valueFn = (
-            entityId: EntityId | undefined
+            entityName: EntityName | undefined
         ): string | ErrorValue => {
-            if (!entityId) return ErrorValueTypes.UndefinedButShouldBeString
-            const entityName =
-                joinedVariablesTable.entityIdToNameMap.get(entityId)
+            if (!entityName) return ErrorValueTypes.UndefinedButShouldBeString
             return entityName && selectedEntityColors
                 ? (selectedEntityColors[entityName] ??
                       ErrorValueTypes.UndefinedButShouldBeString)
                 : ErrorValueTypes.UndefinedButShouldBeString
         }
 
-        const values = joinedVariablesTable.rows.map((row) =>
-            valueFn(row.entityId)
-        )
+        const values =
+            joinedVariablesTable.entityNameColumn.valuesIncludingErrorValues.map(
+                (entityName) => valueFn(entityName as EntityName)
+            )
 
         joinedVariablesTable = joinedVariablesTable.appendColumns([
             {