From d830a0133e4f1007d9318c98130bac049cd0b833 Mon Sep 17 00:00:00 2001 From: Marcel Gerber Date: Mon, 4 Sep 2023 18:39:51 +0200 Subject: [PATCH] enhance(svg): output svg using color `none` instead of `transparent` --- packages/@ourworldindata/grapher/src/facetChart/FacetChart.tsx | 2 +- packages/@ourworldindata/grapher/src/lineCharts/LineChart.tsx | 2 +- .../grapher/src/stackedCharts/StackedAreaChart.tsx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/@ourworldindata/grapher/src/facetChart/FacetChart.tsx b/packages/@ourworldindata/grapher/src/facetChart/FacetChart.tsx index 2204ee7d853..b693690bcb4 100644 --- a/packages/@ourworldindata/grapher/src/facetChart/FacetChart.tsx +++ b/packages/@ourworldindata/grapher/src/facetChart/FacetChart.tsx @@ -60,7 +60,7 @@ import { NumericBin, } from "../color/ColorScaleBin" -const facetBackgroundColor = "transparent" // we don't use color yet but may use it for background later +const facetBackgroundColor = "none" // we don't use color yet but may use it for background later const getContentBounds = ( containerBounds: Bounds, diff --git a/packages/@ourworldindata/grapher/src/lineCharts/LineChart.tsx b/packages/@ourworldindata/grapher/src/lineCharts/LineChart.tsx index ef4d94d35a9..5835fa5950e 100644 --- a/packages/@ourworldindata/grapher/src/lineCharts/LineChart.tsx +++ b/packages/@ourworldindata/grapher/src/lineCharts/LineChart.tsx @@ -733,7 +733,7 @@ export class LineChart onTouchMove={this.onCursorMove} > {clipPath.element} - + {/* This ensures that the parent is big enough such that we get mouse hover events for the whole charting area, including the axis, the entity labels, and the whitespace next to them. We need these to be able to show the tooltip for the first/last year even if the mouse is outside the charting area. */} diff --git a/packages/@ourworldindata/grapher/src/stackedCharts/StackedAreaChart.tsx b/packages/@ourworldindata/grapher/src/stackedCharts/StackedAreaChart.tsx index 0fe578dbd01..aa4d05cef22 100644 --- a/packages/@ourworldindata/grapher/src/stackedCharts/StackedAreaChart.tsx +++ b/packages/@ourworldindata/grapher/src/stackedCharts/StackedAreaChart.tsx @@ -523,7 +523,7 @@ export class StackedAreaChart onTouchMove={this.onCursorMove} > {clipPath.element} - + {/* This ensures that the parent is big enough such that we get mouse hover events for the whole charting area, including the axis, the entity labels, and the whitespace next to them. We need these to be able to show the tooltip for the first/last year even if the mouse is outside the charting area. */}