Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faceting: Shared axis not visible if first chart in row has no data #2127

Closed
marcelgerber opened this issue Apr 24, 2023 · 2 comments · Fixed by #3735
Closed

Faceting: Shared axis not visible if first chart in row has no data #2127

marcelgerber opened this issue Apr 24, 2023 · 2 comments · Fixed by #3735

Comments

@marcelgerber
Copy link
Member

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to https://ourworldindata.org/grapher/life-expectancy?time=earliest..1930&facet=entity&country=WLF~FRA~SWE~ASM
  2. Notice that the first row doesn't have an axis on the left, since there's no data for Wallis and Futuna.
  3. Also notice that it's hard to see the scale being used for France in this case.

Screenshots

image

Additional context

In shared axis mode, we have a rule that the leftmost chart in each row renders the vertical axis, and its neighbouring charts don't display one.

@sophiamersmann
Copy link
Member

sophiamersmann commented May 4, 2023

I think this is similar to #1341 in the sense that in both cases we would need to know whether en entity can be rendered with some data before actually running the transformTable function.

@larsyencken
Copy link
Contributor

Sophia to consider in the context of her table transform proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants