Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a new author fails on unenriched socials block #3576

Closed
mlbrgl opened this issue May 3, 2024 · 0 comments · Fixed by #3578
Closed

Creating a new author fails on unenriched socials block #3576

mlbrgl opened this issue May 3, 2024 · 0 comments · Fixed by #3578

Comments

@mlbrgl
Copy link
Member

mlbrgl commented May 3, 2024

When creating a new author, createGdocAndInsertIntoDb calls loadGdocFromGdocBase with an actual class instance. This means Object.assign(gdoc, obj) overrides _enrichSubclassContent with the base class default implementation, which fails to run the subcalss enrichment.

In the case of authors, this enrichment is necessary for the proper parsing of ArchieML content, so this fails visibly. In other cases, it probably fails more silently.

Currently, this blocks the creation of authors, but we should also evaluate how this affects other types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants