Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdoc chart static previews can only show the default view of a chart #3661

Open
ikesau opened this issue May 28, 2024 · 2 comments
Open

Gdoc chart static previews can only show the default view of a chart #3661

ikesau opened this issue May 28, 2024 · 2 comments

Comments

@ikesau
Copy link
Member

ikesau commented May 28, 2024

We fixed gdoc charts not having a noscript fallback in #3635, but did so using the old WP method of replacing the interactive graphers with static export imgs.

This was good enough in the past, but because it wasn't working correctly for a year, authors got used to being able to embed two views of the same grapher side-by-side on mobile, which isn't supported with the static export fallback strategy (instead, the exact same chart is shown twice)

static exports

I think there are two things we could do here:

  1. Better detect when it's appropriate to show static charts by default (many phones can handle multiple grapher embeds just fine)
  2. Use the Cloudflare worker to show these previews instead, so that they can be configured
@danyx23
Copy link
Contributor

danyx23 commented Jun 5, 2024

Probably switching to dynamic makes sense here and probably in more parts of the website as well. I think it would be worth spiking a bit what it would mean to do this for the entire site and get rid of statically baked thumbnails for grapher charts altogether.

@danyx23
Copy link
Contributor

danyx23 commented Oct 28, 2024

@ikesau I'm somewhat in favour of increasing the scope of this to switch all uses of the statically baked thumbnails to dynamic thumbnails and bumping the size up to 3 days. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants