You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This was good enough in the past, but because it wasn't working correctly for a year, authors got used to being able to embed two views of the same grapher side-by-side on mobile, which isn't supported with the static export fallback strategy (instead, the exact same chart is shown twice)
I think there are two things we could do here:
Better detect when it's appropriate to show static charts by default (many phones can handle multiple grapher embeds just fine)
Use the Cloudflare worker to show these previews instead, so that they can be configured
The text was updated successfully, but these errors were encountered:
Probably switching to dynamic makes sense here and probably in more parts of the website as well. I think it would be worth spiking a bit what it would mean to do this for the entire site and get rid of statically baked thumbnails for grapher charts altogether.
@ikesau I'm somewhat in favour of increasing the scope of this to switch all uses of the statically baked thumbnails to dynamic thumbnails and bumping the size up to 3 days. What do you think?
We fixed gdoc charts not having a noscript fallback in #3635, but did so using the old WP method of replacing the interactive graphers with static export imgs.
This was good enough in the past, but because it wasn't working correctly for a year, authors got used to being able to embed two views of the same grapher side-by-side on mobile, which isn't supported with the static export fallback strategy (instead, the exact same chart is shown twice)
I think there are two things we could do here:
The text was updated successfully, but these errors were encountered: