Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycle 2024.4: Multidimensional data pages #3795

Closed
20 of 43 tasks
Tracked by #3041
marcelgerber opened this issue Jul 17, 2024 · 1 comment
Closed
20 of 43 tasks
Tracked by #3041

Cycle 2024.4: Multidimensional data pages #3795

marcelgerber opened this issue Jul 17, 2024 · 1 comment
Assignees

Comments

@marcelgerber
Copy link
Member

marcelgerber commented Jul 17, 2024

Implementation plan

Current prototype PR: #3657

Must-haves

  • Extract React components from existing data pages
  • URL serialization/deserialization
    • Sensible behaviour if one of the URL params is invalid
    • Load view immediately, even if no URL params present
  • Various baking steps - e.g. SQL queries, hydration
    • Provide faqEntries
    • Provide tagToSlugMap
    • Resolve catalog paths to variable IDs
    • primaryTopic for citation information
    • How to serialize grapher config? And where to get overrides from? API endpoint?
      • Create dict: view to grapher config UUID, then fetch clientside on demand [4h]
    • Image metadata [4h] (see Data page FAQ images are not shown #3862)
    • relatedResearch
    • allCharts
    • Include thumbnail image
    • Performance improvements / caching for baking
    • ... anything else?
  • Make code ready for review [1d]
    • Unify _OWID_MULTI_DIM_CONFIG and _OWID_DATAPAGEV2_PROPS under a single object
    • Add README explaining lingo (dimension, choice, view, choice group, ...)
    • Add config schema
  • Add .env feature flag
  • UX changes for long dropdowns: search bar or scrolling
  • UI improvements [1.5d]
    • Don't break lines in strings if window too narrow
    • How to break "Configure the data" row if too wide? [2h]
    • Update page title as user navigates [1h]
    • Focus/hover states [2h]
    • Supply data page title by default
    • Radio button padding is not clickable [0.5h]
    • Make changing between views less jumpy above-the-fold [2h]
    • Unavailable radio buttons should be disabled, not hidden [1h]
  • What things should go in MDD config?
    • Default selection
    • Probably: Topic page tags
    • Probably: Data page title?
    • Allow for overriding origin metadata / "About this data" section [4h]

Should-haves (will need these at some point!)

  • Mobile styles [may be large project]
  • Authoring
    • Come up with final variableIds format that we can then support
    • Support catalog paths
  • Save things in DB?? [can do this after launch]
  • Enable embedding MDDs [can do this after launch]
    • ... with and without select dropdowns
@marcelgerber marcelgerber changed the title Multidimensional indicators Cycle 2024.4: Multidimensional indicators Jul 17, 2024
@marcelgerber marcelgerber changed the title Cycle 2024.4: Multidimensional indicators Cycle 2024.4: Multidimensional data pages Jul 17, 2024
@marcelgerber marcelgerber self-assigned this Jul 17, 2024
@marcelgerber
Copy link
Member Author

Superseded by #3874, closing.

@marcelgerber marcelgerber closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant