Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grapher redirects aren't working #3958

Closed
ikesau opened this issue Sep 13, 2024 · 3 comments · Fixed by #3959
Closed

Grapher redirects aren't working #3958

ikesau opened this issue Sep 13, 2024 · 3 comments · Fixed by #3959

Comments

@ikesau
Copy link
Member

ikesau commented Sep 13, 2024

Problem

Grapher redirects are not working, and instead serving 404 pages.

Expected behaviour

They should redirect you to the desired different slug.

Example

https://ourworldindata.org/grapher/incidence-of-child-labour-in-the-united-states-1890-1930 should redirect to https://ourworldindata.org/grapher/incidence-of-child-labor-in-the-united-states-1890-1930 but it's not working.

image

Technical notes

  • Site redirects are working
@ikesau
Copy link
Member Author

ikesau commented Sep 13, 2024

A possible candidate might be this change to how we handled 404s in the Grapher worker. https://github.com/owid/owid-grapher/pull/3951/files

@ikesau
Copy link
Member Author

ikesau commented Sep 13, 2024

Confirmed that be9c4e3 is the culprit, as https://f5a632ba.owid.pages.dev/ is the deploy where redirects stop working.

@ikesau
Copy link
Member Author

ikesau commented Sep 13, 2024

@larsyencken larsyencken self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants