Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart editor: Remove "Restore" button from the revisions tab #4134

Closed
sophiamersmann opened this issue Nov 11, 2024 · 0 comments · Fixed by #4323
Closed

Chart editor: Remove "Restore" button from the revisions tab #4134

sophiamersmann opened this issue Nov 11, 2024 · 0 comments · Fixed by #4323
Assignees
@sophiamersmann
Labels
admin Issues that need to be solved in the grapher admin (mostly) cleanup priority 3 - nice to have soonish and small Do it some time soon like next cooldown viz

Comments

@sophiamersmann
Copy link
Member

Authors typically check chart revisions to understand a chart's history but very rarely restore an old chart config version (see Slack).

Since the behaviour for restoring an old chart revision has been broken for a while, and we have little appetite for fixing it, let's remove it from the admin.

Not supporting restore behaviour means that we don't have to worry too much about being able to re-apply a chart revision to an existing chart.
@sophiamersmann sophiamersmann added admin Issues that need to be solved in the grapher admin (mostly) cleanup viz labels Nov 11, 2024
@marcelgerber marcelgerber added soonish and small Do it some time soon like next cooldown priority 3 - nice to have and removed needs triage labels Nov 13, 2024
@sophiamersmann sophiamersmann mentioned this issue Dec 17, 2024
Merged
@sophiamersmann sophiamersmann self-assigned this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sophiamersmann sophiamersmann

Labels
admin Issues that need to be solved in the grapher admin (mostly) cleanup priority 3 - nice to have soonish and small Do it some time soon like next cooldown viz
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🔨 (admin) remove Restore button from history tab owid/owid-grapher
2 participants
@marcelgerber @sophiamersmann