Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: set owncloud trusted domains #23

Merged
merged 10 commits into from
Oct 25, 2022
Merged

chore: set owncloud trusted domains #23

merged 10 commits into from
Oct 25, 2022

Conversation

xoxys
Copy link
Contributor

@xoxys xoxys commented Oct 18, 2022 •
edited
Loading

@xoxys xoxys requested a review from d7oc October 18, 2022 08:33
d7oc
d7oc approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@d7oc d7oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xoxys xoxys marked this pull request as draft October 18, 2022 12:12
@xoxys xoxys requested a review from d7oc October 18, 2022 12:13
d7oc
d7oc approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@d7oc d7oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but don't we need to add the IP of the ingress as well?

@xoxys
Copy link
Contributor Author

xoxys commented Oct 18, 2022

I don't think so, but can't say for sure.

@xoxys xoxys marked this pull request as ready for review October 25, 2022 08:51
@d7oc d7oc merged commit 4fce8a9 into main Oct 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the trusted-domains branch October 25, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7oc d7oc d7oc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xoxys @d7oc