-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added K8s CronJob implementation #45
Conversation
Drop it I would say. |
I'm not that convinced by the huge include block for the env vars. Wouldn't be using a ConfigMap cleaner if we need to share all env vars with other containers? |
We could switch to the ConfigMap (or Secret in here), but the pure amount will still be the same. I'm also not quite sure if there won't be any conflict between the still existing So in a nutshell the template approach sounds simpler to me. |
- added annotation for non-root containers
- changed deleted comment line
That's not what I was talking about. The idea was to just use a ConfigMap to properly share the env vars by using |
Ah this. Ok this might work. Will give it a try. |
- added configmap with all environment variables - added -cronjob to cronjob names - added container restart on config changes via checksum
Done, also tested working on a local OpenShift cluster, please recheck. |
How is |
You're right, this was missing, good catch. Added in c85c92d. |
This PR implements #12.