Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dynamic configMap #5

Merged
merged 8 commits into from
Sep 26, 2022
Merged

feat: add dynamic configMap #5

merged 8 commits into from
Sep 26, 2022

Conversation

d7oc
Copy link
Contributor

@d7oc d7oc commented Sep 23, 2022

  • Added configMap which allows to configure all values dynamically in YAML style in the values section which is then transferred to JSON inside a config.php file.
  • This solution uses a symlink right now as oC10 cannot lookup subdirectories of the config directory yet. This solution has the downside that on container setup there might be a race condition which will heal itself after sometime. This happens if oC10 tries to read the symlink before the volume it refers to is mounted.

@d7oc d7oc mentioned this pull request Sep 23, 2022
@d7oc
Copy link
Contributor Author

d7oc commented Sep 23, 2022

@xoxys I have removed the if conditions to disable the configMap dynamically. As this will not work right now. If everything is disabled the symlink still points to a file which is not existing and we have no means to delete the symlink again in this case. The only solution I see to fix this is adding a reverse config lookup in oC10.

@xoxys xoxys changed the title Added configMap in a dynamic style feat: add dynamic configMap Sep 26, 2022
@xoxys xoxys self-requested a review September 26, 2022 07:41
Copy link
Contributor

@xoxys xoxys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to test it a bit more locally.

Copy link
Contributor

@xoxys xoxys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have slightly changed the default behavior:

  • configExtra is empty by default now
  • an empty configExtra is properly handled to create an empty PHP config snippet

@xoxys xoxys merged commit dbf44e4 into main Sep 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the configMapDraft branch September 26, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants