-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dynamic configMap #5
Conversation
@xoxys I have removed the if conditions to disable the configMap dynamically. As this will not work right now. If everything is disabled the symlink still points to a file which is not existing and we have no means to delete the symlink again in this case. The only solution I see to fix this is adding a reverse config lookup in oC10. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to test it a bit more locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have slightly changed the default behavior:
- configExtra is empty by default now
- an empty configExtra is properly handled to create an empty PHP config snippet
config.php
file.