-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[a11y] 11.1.4.3 Contrast (minimum) #4364
Comments
|
Regarding the colors that need to be changed to meet the contrast requirements, the following research has been carried out:
In conclusion, I would not use the colors found in the system due to these restrictions and instead, I would take the color that meets the contrast requirements and put it in our If we use the Without high contrast fonts: With high contrast fonts: @TheOneRing here is the research and my conclusion on the system colors. If there are any other ideas, please let me know. |
This issue will be blocked until we know how to proceed with the toolbar elements. The background of the toolbar is brandable ( |
Your approach sounds sensible, please continue. |
sure, i will take care |
These will be addressed in #4365, where more changes to the toolbar will be applied |
About ownBrander stuff. There are not many colors to brand there. Not all of them could be affected by non-matching-contrast colors. On the bottom, i am listing the ones that are affected which description should be updated in oB, if all of you agree Splash screen backgroundSplash screen is built with that color on the background and the app icon in the foreground. Here, contrast is not affected since accessibility is not required (no information for dictation or reading) Login screenAlmost everything is brandable in the login view. In that case, it's in the customer's hand to choose colors with correct contrast. On the other hand, there is no accessibility report regarding login view.
Accessibility contrast: delegated to customer. Primary colorWell, after checking a little deeper, i'm disappointed with such option. Apart of the FAB, i did not find any place in the app where the "primary color" is set. Accessibility contrast: The icons inside the buttons are white, so, the color should not be close to the white. Primary text colorText color used within the same buttons as the primary color. I only found this as tint color for the bottom bar icons Accessibility contrast: Should match with the Top bar colorColor of the top bar. But used everywhere in the app: in the search bar, order bar, bottom bar. Also, as color in the details view. That seems to be the real primary color of the app. Accessibility contrast: The search bar, as we already know, will need a tweak. This color is also used in the details view. I don't like this but we can live with it if the color it not close to the white background. General menu headerBackground color on the drawer. Accessibility contrast: Text is white, so, the color should not be close to the white. Color of the space card (oCIS)Color of the space card. Accessibility contrast: view background is white and text inside is black. Something to be careful of, but in the hands of the customers. Where should we warn customers about contrast requirements:
The others, that can collide with white and black could be also involved in problems, but it sounds more weird to have these cases... open to ideas here. |
audit: https://infinite.owncloud.com/s/QtwuiGHikwFjozV
https://www.etsi.org/deliver/etsi_en/301500_301599/301549/03.02.01_60/en_301549v030201p.pdf
https://github.com/BIK-BITV/BIK-App-Test/tree/main/Pr%C3%BCfschritte/de
Note 1: For texts (also in the focused state) under 18 points (or bold text below 14 points), the contrast ratio between foreground and background color should be at least 4.5:1. For large fonts, the contrast ratio should be 3:1 or greater.
Note 2: Since the contrast measurements in the test were carried out using screenshots the test results may differ from the actual color values. It is possible that the colors are displayed differently on the screenshot than on the screen of the device. For this reason, the test results should be regarded as guide values.
Personal Space
The labelling of the "Browse folder" input field does not meet the contrast requirements for texts, as the contrast ratio is only approx. 2.9:1. [MOVED TO [a11y] 11.1.4.11 Non-text contrast #4365]
Both the size information and the time information on the page do not fulfill the contrast requirements for texts, as the contrast ratio is currently well below 4.5:1. The text at the bottom of the page, which shows the number of directories and files also does not meet the contrast requirements for text.
The "Manage accounts" button has a visual label in the form of a letter that does not meet the contrast requirements and is barely recognizable.
Menu
Share
Edit shared Link
Spaces
The text was updated successfully, but these errors were encountered: