Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Multi-Personal (1st round) #4514

Open
5 of 9 tasks
jesmrec opened this issue Nov 15, 2024 · 1 comment
Open
5 of 9 tasks

[FEATURE REQUEST] Multi-Personal (1st round) #4514

jesmrec opened this issue Nov 15, 2024 · 1 comment

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 15, 2024

Now, app is able to connect to one Personal space.

The ability of having multiple Personal should be supported and displayed in the list of spaces as any other one.

TASKS

  • Research (if needed)
  • Create branch feature/multi_personal1
  • Development tasks
    • First approach: show all personal spaces in Spaces tab
    • Implement unit tests (if needed)
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/multi_personal1 into master
@jesmrec
Copy link
Collaborator Author

jesmrec commented Nov 29, 2024

feat: hack not to show the dialog with oC version not supported warning -> fixed via server. Dismissable, nothing to do at this regard.

feat: hack to consider share_jail non-required -> keep it, share_jail shouldn't be required since we ignore it.

feat: hack to consider lastModifiedDateTime, webUrl and driveAlias in spaces non-required -> manual migration in DB. Optional: check which other are also "nullable" to migrate everything at the time.

feat: hack to mock a default quota for multi-personal accounts -> maybe use the capability has_multiple_personal to decide. Check if a better combination of values exist to mock the inexistent quota (no personal as it is). Value "-4" could fit.

feat: hack to retrieve only personal spaces in multi-personal accounts -> use the capability has_multiple_personal to make the decision.

feat: hack to continue with login process even when first PROPFIND returns a 404 -> assuming that the 404 will happen only in case of user light or kws. Done in user light, could dismiss.

feat: hack to show empty view with no personal space in "Personal" tab -> change isLightUser = true with logic to make the decision in base of the quota (-4). Use the capability as condition to add with OR. If user light implements, discard.

feat: hack to avoid refreshes over personal space in "Av. offline" tab -> in users light. To apply everywhere. Discard this commit because a crash is fixed in users light's PR

feat: hack to make spaces header appear with personal spaces as well -> add extra condition to assure that personal spaces show the header whether the capability is true.

feat: hack to show storage information not available message in drawer and manage accounts dialog: fix together with feat: hack to mock a default quota for multi-personal accounts

feat: hack to show correct toolbar and apply correct navigation when entering a personal space -> add extra condition to assure that personal spaces show the header whether the capability is true.

feat: hack not to show space header in "Av. offline" tab -> move forward, no problem.

@jesmrec jesmrec changed the title [FEATURE REQUEST] Multi-Personal [FEATURE REQUEST] Multi-Personal (1st round) Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants